refactor(cdk/drag-drop): Correctly type drag handle parent drag witho… #24664
Conversation
…ut circular dependencies warning Import the `CdkDrag` directive reference as a type-only import to avoid the circular dependency warning.
|
@andrewseguin Old issue with conversation: |
| @@ -18,6 +18,7 @@ import { | |||
| SkipSelf, | |||
| } from '@angular/core'; | |||
| import {Subject} from 'rxjs'; | |||
| import type {CdkDrag} from './drag'; | |||
There was a problem hiding this comment.
If I remember correctly, we aren't allowed to use type imports because the internal JS tooling can't handle them.
There was a problem hiding this comment.
I've confirmed that we can't use type-only imports and exports, because Closure doesn't know how to handle them. I've also submitted #24678 to lint against it automatically.
|
@Achilles1515 It's been a few weeks since a response after the review - do you still want to land this? |
andrewseguin
added
the
needs: clarification
|
@andrewseguin According to the review comments from @crisbeto we can't. |
|
Bummer - sorry about that. Thanks for attempting to make the improvement |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…ut circular dependencies warning
Import the
CdkDragdirective reference as a type-only import to avoid the circular dependency warning.