Skip to content

fix(material-experimental/mdc-radio): switch to new theming API #23725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Oct 11, 2021

Reworks the MDC-based radio button to use the new theming API based on CSS variables.

Also fixes a minor issue where the high contrast styles were emitting slightly more CSS than they need to.

This is forked from #23640, which the commit type changed from feat to fix

Reworks the MDC-based radio button to use the new theming API based on CSS variables.

Also fixes a minor issue where the high contrast styles were emitting slightly more CSS than they need to.
@zarend zarend requested a review from mmalerba as a code owner October 11, 2021 04:10
@google-cla
Copy link

google-cla bot commented Oct 11, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 11, 2021
@zarend zarend added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 11, 2021
@zarend zarend merged commit a259f22 into angular:master Oct 11, 2021
zarend added a commit that referenced this pull request Oct 11, 2021
Reworks the MDC-based radio button to use the new theming API based on CSS variables.

Also fixes a minor issue where the high contrast styles were emitting slightly more CSS than they need to.

Co-authored-by: Kristiyan Kostadinov <crisbeto@abv.bg>
(cherry picked from commit a259f22)
zarend added a commit that referenced this pull request Oct 11, 2021
Reworks the MDC-based radio button to use the new theming API based on CSS variables.

Also fixes a minor issue where the high contrast styles were emitting slightly more CSS than they need to.

Co-authored-by: Kristiyan Kostadinov <crisbeto@abv.bg>
(cherry picked from commit a259f22)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants