feat(material-experimental/mdc-radio): switch to new theming API #23640
Conversation
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
|
Internal tests look good, except that the disabled color seems really faint. Can you double check that the disabled state color matches spec? |
| .mdc-radio { | ||
| // MDC theme styles also include structural styles so we have to include the theme at least | ||
| // once here. The values will be overwritten by our own theme file afterwards. | ||
| @include mdc-radio-theme.theme-styles(mdc-radio-theme.$light-theme); |
There was a problem hiding this comment.
Should we turn off fallback values going forward, and just tell the theming system to slot the variables?
There was a problem hiding this comment.
This is the mixin that slots the variables. I'd rather keep the fallbacks for now and we can have a separate PR that turns them off for all the components using the new API.
Reworks the MDC-based radio button to use the new theming API based on CSS variables. Also fixes a minor issue where the high contrast styles were emitting slightly more CSS than they need to.
crisbeto
force-pushed
the
mdc-radio-theme-mixins
branch
from
5f9855a to
9787132
Compare
|
I've pushed a fix for the disabled color issue. |
zarend
added
target: rc
|
closed in favor of #23725 (which is identical code but changes commit type from |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Reworks the MDC-based radio button to use the new theming API based on CSS variables.
Also fixes a minor issue where the high contrast styles were emitting slightly more CSS than they need to.