test(material/menu): switch all tests to fakeAsync #23203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
added
merge safe
P3
crisbeto
force-pushed
the
menu-async-tests
branch
3 times, most recently
from
00027c2 to
bd48a54
Compare
We were only using `fakeAsync` on about half of the menu tests which could cause state to leak between them. These changes add `fakeAsync` to all of them to try and address the recent flakes that we've been seeing.
crisbeto
force-pushed
the
menu-async-tests
branch
from
bd48a54 to
8b04188
Compare
devversion
approved these changes
Jul 21, 2021
mmalerba
pushed a commit
that referenced
this pull request
Jul 23, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only using
fakeAsyncon about half of the menu tests which could cause state to leak between them. These changes addfakeAsyncto all of them to try and address the recent flakes that we've been seeing.