Skip to content

test(material-experimental/mdc-slider): add tests for slider with set… #22238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions src/material-experimental/mdc-slider/slider.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,88 @@ describe('MDC-based MatSlider' , () => {
expect(endInputInstance.value).toBe(99.7);
});
});

describe('slider with custom thumb label formatting', () => {
let fixture: ComponentFixture<DiscreteSliderWithDisplayWith>;
let sliderInstance: MatSlider;
let valueIndicatorTextElement: Element;

beforeEach(() => {
fixture = createComponent(DiscreteSliderWithDisplayWith);
fixture.detectChanges();
const sliderDebugElement = fixture.debugElement.query(By.directive(MatSlider))!;
const sliderNativeElement = sliderDebugElement.nativeElement;
sliderInstance = sliderDebugElement.componentInstance;
valueIndicatorTextElement =
sliderNativeElement.querySelector('.mdc-slider__value-indicator-text')!;
});

it('should invoke the passed-in `displayWith` function with the value', () => {
spyOn(fixture.componentInstance, 'displayWith').and.callThrough();
sliderInstance._setValue(1337, Thumb.END);
fixture.whenStable().then(() => {
expect(fixture.componentInstance.displayWith).toHaveBeenCalledWith(1337);
});
});

it('should format the thumb label based on the passed-in `displayWith` function', () => {
sliderInstance._setValue(200000, Thumb.END);
fixture.whenStable().then(() => {
expect(valueIndicatorTextElement.textContent).toBe('200k');
});
});
});

describe('slider with custom thumb label formatting', () => {
let fixture: ComponentFixture<DiscreteRangeSliderWithDisplayWith>;
let sliderInstance: MatSlider;
let startValueIndicatorTextElement: Element;
let endValueIndicatorTextElement: Element;

beforeEach(() => {
fixture = createComponent(DiscreteRangeSliderWithDisplayWith);
fixture.detectChanges();
const sliderDebugElement = fixture.debugElement.query(By.directive(MatSlider))!;
sliderInstance = sliderDebugElement.componentInstance;

const startThumbElement = sliderInstance._getThumbElement(Thumb.START);
const endThumbElement = sliderInstance._getThumbElement(Thumb.END);
startValueIndicatorTextElement =
startThumbElement.querySelector('.mdc-slider__value-indicator-text')!;
endValueIndicatorTextElement =
endThumbElement.querySelector('.mdc-slider__value-indicator-text')!;
});

it('should invoke the passed-in `displayWith` function with the start value', () => {
spyOn(fixture.componentInstance, 'displayWith').and.callThrough();
sliderInstance._setValue(1337, Thumb.START);
fixture.whenStable().then(() => {
expect(fixture.componentInstance.displayWith).toHaveBeenCalledWith(1337);
});
});

it('should invoke the passed-in `displayWith` function with the end value', () => {
spyOn(fixture.componentInstance, 'displayWith').and.callThrough();
sliderInstance._setValue(5996, Thumb.END);
fixture.whenStable().then(() => {
expect(fixture.componentInstance.displayWith).toHaveBeenCalledWith(5996);
});
});

it('should format the start thumb label based on the passed-in `displayWith` function', () => {
sliderInstance._setValue(200000, Thumb.START);
fixture.whenStable().then(() => {
expect(startValueIndicatorTextElement.textContent).toBe('200k');
});
});

it('should format the end thumb label based on the passed-in `displayWith` function', () => {
sliderInstance._setValue(700000, Thumb.END);
fixture.whenStable().then(() => {
expect(endValueIndicatorTextElement.textContent).toBe('700k');
});
});
});
});


Expand Down Expand Up @@ -744,6 +826,35 @@ class SliderWithStep {}
})
class RangeSliderWithStep {}

@Component({
template: `
<mat-slider [displayWith]="displayWith" min="1" max="1000000" discrete>
<input matSliderThumb>
</mat-slider>
`,
})
class DiscreteSliderWithDisplayWith {
displayWith(v: number) {
if (v >= 1000) { return `$${v / 1000}k`; }
return `$${v}`;
}
}

@Component({
template: `
<mat-slider [displayWith]="displayWith" min="1" max="1000000" discrete>
<input matSliderStartThumb>
<input matSliderEndThumb>
</mat-slider>
`,
})
class DiscreteRangeSliderWithDisplayWith {
displayWith(v: number) {
if (v >= 1000) { return `$${v / 1000}k`; }
return `$${v}`;
}
}

/** The pointer event types used by the MDC Slider. */
const enum PointerEventType {
POINTER_DOWN = 'pointerdown',
Expand Down
1 change: 1 addition & 0 deletions src/material-experimental/mdc-slider/slider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,7 @@ export class MatSlider extends _MatSliderMixinBase
thumbPosition === Thumb.START
? this._startValueIndicatorText = this.displayWith(value)
: this._endValueIndicatorText = this.displayWith(value);
this._cdr.markForCheck();
}

/** Gets the value indicator text for the given thumb position. */
Expand Down