Skip to content

test(material-experimental/mdc-slider): add tests for slider with set… #22238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

wagnermaciel
Copy link
Contributor

… displayWith

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2021
@wagnermaciel wagnermaciel added the target: feature This PR is targeted for a feature branch (outside of main and semver branches) label Mar 15, 2021
@wagnermaciel wagnermaciel marked this pull request as ready for review March 15, 2021 19:08
@wagnermaciel wagnermaciel requested review from crisbeto and mmalerba and removed request for devversion March 15, 2021 19:08
@wagnermaciel
Copy link
Contributor Author

Blocked by #22232

@wagnermaciel wagnermaciel added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Mar 15, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Mar 15, 2021
@wagnermaciel wagnermaciel merged commit 0a9399d into angular:mdc-slider Mar 15, 2021
@wagnermaciel wagnermaciel deleted the mdc-slider-unit-tests branch March 15, 2021 19:40
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 15, 2021
angular#22238)

* test(material-experimental/mdc-slider): add tests for slider with set displayWith

* fix(material-experimental/mdc-slider): trigger change detection when the value indicator text changes
wagnermaciel added a commit that referenced this pull request Mar 18, 2021
#22238)

* test(material-experimental/mdc-slider): add tests for slider with set displayWith

* fix(material-experimental/mdc-slider): trigger change detection when the value indicator text changes
wagnermaciel added a commit that referenced this pull request Mar 18, 2021
#22238)

* test(material-experimental/mdc-slider): add tests for slider with set displayWith

* fix(material-experimental/mdc-slider): trigger change detection when the value indicator text changes
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 23, 2021
angular#22238)

* test(material-experimental/mdc-slider): add tests for slider with set displayWith

* fix(material-experimental/mdc-slider): trigger change detection when the value indicator text changes
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Apr 1, 2021
angular#22238)

* test(material-experimental/mdc-slider): add tests for slider with set displayWith

* fix(material-experimental/mdc-slider): trigger change detection when the value indicator text changes
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Apr 2, 2021
angular#22238)

* test(material-experimental/mdc-slider): add tests for slider with set displayWith

* fix(material-experimental/mdc-slider): trigger change detection when the value indicator text changes
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Apr 8, 2021
angular#22238)

* test(material-experimental/mdc-slider): add tests for slider with set displayWith

* fix(material-experimental/mdc-slider): trigger change detection when the value indicator text changes
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants