fix(cdk/a11y): focusVia not accounting for focused child node #21512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
In angular#20966 some logic was added so that calling `focusVia` on an element that already has focus would change the origin to the passed-in one. The problem is that the new logic doesn't account for when a parent element is monitored and `focusVia` is called on a child. These changes add some more logic that will look through all the monitored elements that have `checkChildren: true` and will switch the origin accordingly. Fixes angular#21500.
crisbeto
force-pushed
the
21500/focus-monitor-focus-via
branch
from
c9a63a6 to
2540419
Compare
|
LGTM |
annieyw
pushed a commit
that referenced
this pull request
Jan 9, 2021
In #20966 some logic was added so that calling `focusVia` on an element that already has focus would change the origin to the passed-in one. The problem is that the new logic doesn't account for when a parent element is monitored and `focusVia` is called on a child. These changes add some more logic that will look through all the monitored elements that have `checkChildren: true` and will switch the origin accordingly. Fixes #21500. (cherry picked from commit f8df9f8)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…r#21512) In angular#20966 some logic was added so that calling `focusVia` on an element that already has focus would change the origin to the passed-in one. The problem is that the new logic doesn't account for when a parent element is monitored and `focusVia` is called on a child. These changes add some more logic that will look through all the monitored elements that have `checkChildren: true` and will switch the origin accordingly. Fixes angular#21500.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #20966 some logic was added so that calling
focusViaon an element that already has focus would change the origin to the passed-in one. The problem is that the new logic doesn't account for when a parent element is monitored andfocusViais called on a child.These changes add some more logic that will look through all the monitored elements that have
checkChildren: trueand will switch the origin accordingly.Fixes #21500.
cc @zelliott