fix(cdk/a11y): allow for origin of already focused element to be changed #20966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
20965/focus-monitor-origin
branch
from
0be46e7 to
a2455c6
Compare
The way `FocusMonitor.focusVia` works is by calling `focus` on the specified element and waiting for a `focus` event to trigger so the origin is applied. The problem is that if `focusVia` is called on an element that already has focus, the event won't be dispatched and the origin won't be updated which can cause the UI to look stuck. These changes make it so that if we detect that an element is focused already, we update its classes and dispatch the relevant event without trying to focus it. Related to angular#20965.
crisbeto
force-pushed
the
20965/focus-monitor-origin
branch
from
a2455c6 to
e17409c
Compare
annieyw
pushed a commit
that referenced
this pull request
Nov 7, 2020
…ged (#20966) The way `FocusMonitor.focusVia` works is by calling `focus` on the specified element and waiting for a `focus` event to trigger so the origin is applied. The problem is that if `focusVia` is called on an element that already has focus, the event won't be dispatched and the origin won't be updated which can cause the UI to look stuck. These changes make it so that if we detect that an element is focused already, we update its classes and dispatch the relevant event without trying to focus it. Related to #20965. (cherry picked from commit c1ab0b8)
annieyw
pushed a commit
that referenced
this pull request
Nov 7, 2020
…ged (#20966) The way `FocusMonitor.focusVia` works is by calling `focus` on the specified element and waiting for a `focus` event to trigger so the origin is applied. The problem is that if `focusVia` is called on an element that already has focus, the event won't be dispatched and the origin won't be updated which can cause the UI to look stuck. These changes make it so that if we detect that an element is focused already, we update its classes and dispatch the relevant event without trying to focus it. Related to #20965. (cherry picked from commit c1ab0b8)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
FocusMonitor.focusViaworks is by callingfocuson the specified element and waiting for afocusevent to trigger so the origin is applied. The problem is that iffocusViais called on an element that already has focus, the event won't be dispatched and the origin won't be updated which can cause the UI to look stuck.These changes make it so that if we detect that an element is focused already, we update its classes and dispatch the relevant event without trying to focus it.
Related to #20965.