Skip to content

fix(material-experimental/mdc-snack-bar): simple snack button should be accent #21384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2021
Merged

fix(material-experimental/mdc-snack-bar): simple snack button should be accent #21384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/material-experimental/mdc-snack-bar/_snack-bar-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@
$mdc-snackbar-fill-color: $orig-mdc-snackbar-fill-color !global;
$mdc-snackbar-label-ink-color: $orig-mdc-snackbar-label-ink-color !global;
$mdc-snackbar-dismiss-ink-color: $orig-mdc-snackbar-dismiss-ink-color !global;

.mat-mdc-simple-snack-bar .mdc-snackbar__action {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we achieve the same by setting color="accent" on the button in simple-snack-bar.html or will that not work correctly in dark themes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought was that it's possible, albeit really unlikely, that someone imports the snackbar theme but never imports the button theme.

$is-dark-theme: map-get($config, is-dark);
$accent: map-get($config, accent);
color: if($is-dark-theme, inherit, mat-color($accent, text));
}
}

@mixin mat-mdc-snack-bar-typography($config-or-theme) {
Expand Down