fix(material-experimental/mdc-snack-bar): simple snack button should be accent #21384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
the
target: patch
google-cla
bot
added
the
cla: yes
crisbeto
approved these changes
Dec 18, 2020
| @@ -31,6 +31,12 @@ | |||
| $mdc-snackbar-fill-color: $orig-mdc-snackbar-fill-color !global; | |||
| $mdc-snackbar-label-ink-color: $orig-mdc-snackbar-label-ink-color !global; | |||
| $mdc-snackbar-dismiss-ink-color: $orig-mdc-snackbar-dismiss-ink-color !global; | |||
|
|
|||
| .mat-mdc-simple-snack-bar .mdc-snackbar__action { | |||
There was a problem hiding this comment.
Could we achieve the same by setting color="accent" on the button in simple-snack-bar.html or will that not work correctly in dark themes?
There was a problem hiding this comment.
My thought was that it's possible, albeit really unlikely, that someone imports the snackbar theme but never imports the button theme.
mmalerba
added
the
P2
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the styles found in our current snack bar, which causes the button to be accent in light theme and inherit in dark. Otherwise, MDC colors it according to their default button color