Skip to content

refactor(material/tree): change MatNodeHarness to extend ContentContainerComponentHarness #20591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2020
Merged

refactor(material/tree): change MatNodeHarness to extend ContentContainerComponentHarness #20591

merged 1 commit into from
Oct 2, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Sep 16, 2020

#20556 switched some component harnesses to extend ContentContainerComponentHarness to allow users to query for harnesses inside the components but MatTreeHarness is not merged yet.

@annieyw annieyw requested a review from mmalerba September 16, 2020 20:16
@annieyw annieyw requested review from andrewseguin, jelbourn and a team as code owners September 16, 2020 20:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 16, 2020
@annieyw annieyw added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Sep 16, 2020
@annieyw annieyw force-pushed the refactor-tree-harness branch from dbf0845 to c7314fa Compare September 16, 2020 20:26
mmalerba
mmalerba approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the target: minor This PR is targeted for the next minor release label Sep 16, 2020
@annieyw annieyw force-pushed the refactor-tree-harness branch from c7314fa to 97cbc46 Compare September 23, 2020 18:36
@annieyw annieyw added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Sep 23, 2020
@annieyw annieyw changed the title refactor(tree/testing): change MatNodeHarness to extend ContentContainerComponentHarness refactor(material/tree): change MatNodeHarness to extend ContentContainerComponentHarness Sep 23, 2020
@mmalerba mmalerba merged commit 8d47159 into angular:master Oct 2, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2020
@annieyw annieyw deleted the refactor-tree-harness branch November 2, 2020 04:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annieyw @mmalerba @googlebot