refactor(testing): add methods for accessing projected content in component container harnesses #20556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
…ponent container harnesses Switches over all the harnesses for components that can contain projected user content to extend `ContentContainerComponentHarness` which will allow consumers to query for harnesses inside the element. I've also deprecated a few similar methods that were added before `ContentContainerComponentHarness` was available. That being said, I wasn't totally sure whether the testing APIs fall under the same deprecation policy as everything else so I played it safe. Finally, I cleaned up some `@dynamic` annotations which weren't doing anything, as far as I could tell.
crisbeto
force-pushed
the
COMP-294/content-container-harnesses
branch
from
4fa28ad to
ce65f84
Compare
mmalerba
added
P2
mmalerba
added
G
devversion
approved these changes
Sep 14, 2020
devversion
reviewed
Sep 14, 2020
| import {coerceBooleanProperty} from '@angular/cdk/coercion'; | ||
| import {MenuHarnessFilters, MenuItemHarnessFilters} from '@angular/material/menu/testing'; | ||
|
|
||
| /** Harness for interacting with an MDC-based mat-menu in tests. */ | ||
| export class MatMenuHarness extends ComponentHarness { | ||
| export class MatMenuHarness extends ContentContainerComponentHarness<string> { |
There was a problem hiding this comment.
Should we implement ContentContainerComponentHarness rather? (for all similar harnesses too). That would help us enforce the methods being properly overridden and a consistent signature/API. Also looks like the base class isn't used at runtime anyway.
There was a problem hiding this comment.
I'll do a follow-up to try and make it so we don't have to override these methods, but we pass in something through the constructor instead.
wagnermaciel
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches over all the harnesses for components that can contain projected user content to extend
ContentContainerComponentHarnesswhich will allow consumers to query for harnesses inside the element.I've also deprecated a few similar methods that were added before
ContentContainerComponentHarnesswas available. That being said, I wasn't totally sure whether the testing APIs fall under the same deprecation policy as everything else so I played it safe.Finally, I cleaned up some
@dynamicannotations which weren't doing anything, as far as I could tell.