Skip to content

build: integration size tests should not cause failure in CI #19829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020
Merged

build: integration size tests should not cause failure in CI #19829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,13 @@ jobs:
- *setup_bazel_remote_execution
- *yarn_install
- *setup_bazel_binary
- run: yarn integration-tests
# TODO: Re-enable when there are integration tests that should run with Ivy.
# Currently this command fails as there are no tests.
# - run: yarn integration-tests
- run:
name: Running size integration tests (failures are reported in Slack only).
command: |
yarn integration-tests:size-test || ./scripts/circleci/notify-slack-job-failure.sh
- run: yarn integration-tests:view-engine
- *slack_notify_on_failure

Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@
"merge": "ng-dev pr merge",
"approve-api": "node ./scripts/approve-api-golden.js",
"approve-size-tests": "node ./scripts/approve-size-golden.js",
"integration-tests": "bazel test //integration/... --test_tag_filters=-view-engine-only --build_tests_only",
"integration-tests:view-engine": "bazel test //integration/... --test_tag_filters=view-engine-only --build_tests_only --config=view-engine"
"integration-tests": "bazel test --test_tag_filters=-view-engine-only --build_tests_only -- //integration/... -//integration/size-test/...",
"integration-tests:view-engine": "bazel test --test_tag_filters=view-engine-only --build_tests_only -- //integration/... -//integration/size-test/...",
"integration-tests:size-test": "bazel test //integration/size-test/..."
},
"version": "10.1.0-next.0",
"dependencies": {
Expand Down