Skip to content

build: integration size tests should not cause failure in CI #19829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Jul 1, 2020

Disables the size test integration tests until we have a better concept for reporting size regressions. For now we disable them in the CI but report failures to the #components-ci-failures Slack channel.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 1, 2020
@devversion devversion force-pushed the build/hide-size-test-golden-failures branch 2 times, most recently from a52b379 to a1d3ff7 Compare July 1, 2020 17:25
@devversion devversion force-pushed the build/hide-size-test-golden-failures branch from a1d3ff7 to 4f71d4c Compare July 1, 2020 17:29
@devversion devversion added merge safe target: minor This PR is targeted for the next minor release labels Jul 1, 2020
@devversion devversion marked this pull request as ready for review July 1, 2020 17:33
@devversion devversion requested a review from a team as a code owner July 1, 2020 17:33
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 1, 2020
@jelbourn jelbourn merged commit db4b0cd into angular:master Jul 1, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants