build: ci failure notifications accidentally skipped #19631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like we currently incorrectly skip when the `CIRCLE_PR_NUMBER` variable is _not_ defined. It should be the other way around though, and we want to only skip when this variable is defined/not-null
devversion
added
P3
googlebot
added
the
cla: yes
josephperrott
added
lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jun 15, 2020
Looks like we currently incorrectly skip when the `CIRCLE_PR_NUMBER` variable is _not_ defined. It should be the other way around though, and we want to only skip when this variable is defined/not-null
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we currently incorrectly skip notifications when the
CIRCLE_PR_NUMBERvariable is not defined. It should be the other way around though, and we want
to only skip notifications when this variable is defined/not-null (i.e. skip notifications for PRs that don't have access to the webhook secret variable anyway).