Skip to content

Commit 60045a4

Browse files
devversionandrewseguin
authored andcommitted
build: ci failure notifications accidentally skipped (#19631)
Looks like we currently incorrectly skip when the `CIRCLE_PR_NUMBER` variable is _not_ defined. It should be the other way around though, and we want to only skip when this variable is defined/not-null
1 parent a57668a commit 60045a4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/circleci/notify-slack-job-failure.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Script that notifies Slack about the currently failing job. This script
44
# will be a noop when running for forked builds (i.e. PRs).
55

6-
if [[ -z "${CIRCLE_PR_NUMBER}" ]]; then
6+
if [[ -n "${CIRCLE_PR_NUMBER}" ]]; then
77
echo "Skipping notification for pull request."
88
exit 0
99
fi

0 commit comments

Comments
 (0)