Skip to content

build: enable license header linting for benchmark tests #19597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

Enables license header linting for the benchmark tests
folder. This seems needed because in order to sync these files
into g3, the license header must be correct/added.

Related to #19596.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2020
@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR merge safe target: patch This PR is targeted for the next patch release labels Jun 10, 2020
@devversion
Copy link
Member Author

Currently blocked on #19596 landing, so that the lint job is green again.

@devversion devversion marked this pull request as ready for review June 10, 2020 18:24
@devversion devversion requested review from jelbourn and a team as code owners June 10, 2020 18:24
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Enables license header linting for the benchmark tests
folder. This seems needed because in order to sync these files
into g3, the license header must be correct/added.

Related to angular#19596.
@devversion devversion force-pushed the build/enable-linting-benchmarks-for-g3-sync branch from 3ff6a0a to f0085a1 Compare June 10, 2020 20:13
@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Jun 10, 2020
@jelbourn jelbourn removed lgtm action: merge The PR is ready for merge by the caretaker labels Jun 10, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 10, 2020
@andrewseguin andrewseguin merged commit e92a5f6 into angular:master Jun 12, 2020
andrewseguin pushed a commit that referenced this pull request Jun 12, 2020
Enables license header linting for the benchmark tests
folder. This seems needed because in order to sync these files
into g3, the license header must be correct/added.

Related to #19596.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants