Skip to content

fix(benchmark): fix license header and correct test descriptions #19596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

wagnermaciel
Copy link
Contributor

Fix

  • Fix license header so that we can copybara sync this into google3

Cleanup

  • Remove use of the word "overview. This was a remnant from when we thought we would use the checkbox-overview-example. Since this is no longer the case (and since I'm already making a small change here), it would be good to remove it.

@wagnermaciel wagnermaciel requested a review from a team as a code owner June 10, 2020 17:07
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2020
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 10, 2020
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

devversion added a commit to devversion/material2 that referenced this pull request Jun 10, 2020
Enables license header linting for the benchmark tests
folder. This seems needed because in order to sync these files
into g3, the license header must be correct/added.

Related to angular#19596.
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 0d266e2 into angular:master Jun 10, 2020
devversion added a commit to devversion/material2 that referenced this pull request Jun 10, 2020
Enables license header linting for the benchmark tests
folder. This seems needed because in order to sync these files
into g3, the license header must be correct/added.

Related to angular#19596.
andrewseguin pushed a commit that referenced this pull request Jun 12, 2020
Enables license header linting for the benchmark tests
folder. This seems needed because in order to sync these files
into g3, the license header must be correct/added.

Related to #19596.
andrewseguin pushed a commit that referenced this pull request Jun 12, 2020
Enables license header linting for the benchmark tests
folder. This seems needed because in order to sync these files
into g3, the license header must be correct/added.

Related to #19596.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2020
@wagnermaciel wagnermaciel deleted the checkbox-perf-spec-cleanup branch January 14, 2021 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants