-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(benchmark): fix license header and correct test descriptions #19596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(benchmark): fix license header and correct test descriptions #19596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Enables license header linting for the benchmark tests folder. This seems needed because in order to sync these files into g3, the license header must be correct/added. Related to angular#19596.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enables license header linting for the benchmark tests folder. This seems needed because in order to sync these files into g3, the license header must be correct/added. Related to angular#19596.
Enables license header linting for the benchmark tests folder. This seems needed because in order to sync these files into g3, the license header must be correct/added. Related to #19596.
Enables license header linting for the benchmark tests folder. This seems needed because in order to sync these files into g3, the license header must be correct/added. Related to #19596.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix
Cleanup
checkbox-overview-example
. Since this is no longer the case (and since I'm already making a small change here), it would be good to remove it.