fix(cdk/testing): Make harnesses click on the center of the element by default #19212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
P2
googlebot
added
the
cla: yes
devversion
reviewed
Apr 29, 2020
|
Could you also expand the commit message with more context about the fix? |
crisbeto
reviewed
Apr 30, 2020
…y default This is Protractor's default behavior. Prior to this PR we had been clicking the top-left corner, but that didn't trigger the click event in Protractor.
mmalerba
changed the title
devversion
approved these changes
Apr 30, 2020
|
Yeah this is technically breaking, since I'm not allowing you to pass only |
jelbourn
pushed a commit
that referenced
this pull request
May 1, 2020
…y default (#19212) * fix(cdk/testing): Make harnesses click on the center of the element by default This is Protractor's default behavior. Prior to this PR we had been clicking the top-left corner, but that didn't trigger the click event in Protractor. * address feedback * clarifying comment * update api goldens
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Protractor's default behavior. Prior to this PR we had been
clicking the top-left corner, but that didn't trigger the click event in
Protractor.
fixes #19002