address feedback

Author: mmalerba

src/cdk/testing/protractor/protractor-element.ts

@@ -73,9 +73,10 @@ export class ProtractorElement implements TestElement {
     return this.element.clear();
   }
 
-  async click(relativeX = 1, relativeY = 1): Promise<void> {
+  async click(...args: number[]): Promise<void> {
+    const offsetArgs = args.length ? [{x: args[0], y: args[1]}] : [];
     await browser.actions()
-      .mouseMove(await this.element.getWebElement(), {x: relativeX, y: relativeY})
+      .mouseMove(await this.element.getWebElement(), ...offsetArgs)
       .click()
       .perform();
   }

src/cdk/testing/test-element.ts

@@ -67,12 +67,15 @@ export interface TestElement {
   /** Clear the element's input (for input and textarea elements only). */
   clear(): Promise<void>;
 
+  /** Click the element at the element's center. */
+  click(): Promise<void>;
+
   /**
-   * Click the element.
+   * Click the element at the specified coordinates relative to the top-left of the element.
    * @param relativeX Coordinate within the element, along the X-axis at which to click.
    * @param relativeY Coordinate within the element, along the Y-axis at which to click.
    */
-  click(relativeX?: number, relativeY?: number): Promise<void>;
+  click(relativeX: number, relativeY: number): Promise<void>;
 
   /** Focus the element. */
   focus(): Promise<void>;

src/cdk/testing/testbed/unit-test-element.ts

@@ -71,9 +71,11 @@ export class UnitTestElement implements TestElement {
     await this._stabilize();
   }
 
-  async click(relativeX = 1, relativeY = 1): Promise<void> {
-    await this._stabilize();
-    const {left, top} = this.element.getBoundingClientRect();
+  async click(...args: number[]): Promise<void> {
+    const {left, top, width, height} = await this.getDimensions();
+    const relativeX = args.length ? args[0] : width / 2;
+    const relativeY = args.length ? args[1] : height / 2;
+
     // Round the computed click position as decimal pixels are not
     // supported by mouse events and could lead to unexpected results.
     const clientX = Math.round(left + relativeX);

src/material/button/testing/button-harness.e2e.spec.ts

@@ -1,5 +1,5 @@
 import {ProtractorHarnessEnvironment} from '@angular/cdk/testing/protractor';
-import {MatButtonHarness} from '@angular/material/button/testing/button-harness';
+import {MatButtonHarness} from '@angular/material/button/testing';
 import {browser} from 'protractor';
 
 describe('button harness', () => {