Skip to content

build: run saucelabs and browserstack tests with ivy #18276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2020
Merged

build: run saucelabs and browserstack tests with ivy #18276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/gulp/tasks/unit-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ task(':test:build-system-config', () => {
const configOutputPath = join(buildConfig.outputDir, 'karma-system-config.js');
shelljs.cd(buildConfig.projectDir);
const bazelGenfilesDir = shelljs.exec('yarn -s bazel info bazel-genfiles').stdout.trim();
shelljs.exec('yarn -s bazel build //test:system-config.js --config=view-engine');
shelljs.exec('yarn -s bazel build //test:system-config.js');
shelljs.cp(join(bazelGenfilesDir, 'test/system-config.js'), configOutputPath);
shelljs.chmod('u+w', configOutputPath);
});
7 changes: 4 additions & 3 deletions tools/system-config-tmpl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,10 @@ function setupFrameworkPackages() {
var entryPointName = segments.length ? moduleName + '/' + segments.join('/') : moduleName;
var bundlePath = 'bundles/' + bundleName;
// When running with Ivy, we need to load the ngcc processed UMD bundles.
// These are stored in the "__ivy_ngcc_" folder that has been generated
// since we run ngcc with "--create-ivy-entry-points".
if (isRunningWithIvy) {
// These are stored in the `__ivy_ngcc_` folder that has been generated
// since we run ngcc with `--create-ivy-entry-points`. Filter out the compiler
// package because it won't be processed by ngcc.
if (isRunningWithIvy && entryPointName !== '@angular/compiler') {
bundlePath = '__ivy_ngcc__/' + bundlePath;
}
packagesConfig[entryPointName] = {
Expand Down