build: run saucelabs and browserstack tests with ivy #18276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
|
Looks like some CI failures |
We recently regressed when we switched to the auto-generated SystemJS configuration in terms of how those legacy karma tests run. Previously they ran with Ivy, but currently they run with view engine. We should switch them back to Ivy since Ivy is the default in version 9.
devversion
force-pushed
the
build/run-saucelabs-browserstack-tests-with-ivy
branch
from
0dd5bdb to
38ff823
Compare
|
@jelbourn Fixed. |
jelbourn
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
We recently regressed when we switched to the auto-generated SystemJS configuration in terms of how those legacy karma tests run. Previously they ran with Ivy, but currently they run with view engine. We should switch them back to Ivy since Ivy is the default in version 9.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently regressed when we switched to the auto-generated
SystemJS configuration in terms of how those legacy karma tests
run. Previously they ran with Ivy, but currently they run with view
engine. We should switch them back to Ivy since Ivy is the default in
version 9.