Skip to content

build: exclude devserver targets from ci test jobs #17990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
+4 −7
Merged

build: exclude devserver targets from ci test jobs #17990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dev-app/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ dev_server(
# artifact output as workspace root.
"angular_material",
],
tags = ["manual"],
deps = [
":dev-app",
],
Expand Down
10 changes: 3 additions & 7 deletions src/e2e-app/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,14 @@ sass_binary(
ts_devserver(
name = "devserver",
testonly = True,
# Root paths can be used simplify the loading of files from external Bazel repositories
# (such as the Bazel managed deps repository called "npm")
additional_root_paths = [
"npm/node_modules",
],
# Name of the AMD module that should be required on page load.
entry_module = "angular_material/src/e2e-app/main",
port = 4200,
# Scripts which will be included in the serving_path bundle after "require.js" has been
# loaded.
# TODO(jelbourn): remove UMDs from here once we don't have to manually include them
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this TODO since it makes sense to exclude them manually (and we already made this less hard-coded). Also removed a few comments that were not necessary since it's obvious and we don't do it for other devserver targets.

# Scripts which will be included in the serving_path bundle after
# RequireJS has been loaded.
scripts = [
":devserver-configure.js",
"//tools/rxjs:rxjs_umd_modules",
Expand All @@ -120,7 +117,6 @@ ts_devserver(
":index.html",
":theme",
],
# Dependencies that produce JavaScript output will be automatically included in the
# serving_path bundle
tags = ["manual"],
deps = [":e2e-app"],
)