build: exclude devserver targets from ci test jobs #17990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to build the runfile tree's for the executable devserver targets. In the CI, we are only interested in building the actual "ng_module" target to ensure the dev-app/e2e-app are not broken. Building the devserver runfiles is just wasteful.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
commented
Dec 17, 2019
| additional_root_paths = [ | ||
| "npm/node_modules", | ||
| ], | ||
| # Name of the AMD module that should be required on page load. | ||
| entry_module = "angular_material/src/e2e-app/main", | ||
| port = 4200, | ||
| # Scripts which will be included in the serving_path bundle after "require.js" has been | ||
| # loaded. | ||
| # TODO(jelbourn): remove UMDs from here once we don't have to manually include them |
There was a problem hiding this comment.
I removed this TODO since it makes sense to exclude them manually (and we already made this less hard-coded). Also removed a few comments that were not necessary since it's obvious and we don't do it for other devserver targets.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to build the runfile tree's for the executable
devserver targets. In the CI, we are only interested in building
the actual "ng_module" target to ensure the dev-app/e2e-app are
not broken. Building the devserver runfiles is just wasteful.
I looked for more targets that we could exclude, but didn't find any..