Skip to content

Make the selection model injectable and add an overlaps method #17766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

xlou978
Copy link
Collaborator

@xlou978 xlou978 commented Nov 21, 2019

Added overlaps method to MatDateSelectionModel.
We didn't copy the contains() method, since it doesn't seem like it's used.

* Adds a date selection model

* Adds a date selection model
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 21, 2019
@xlou978 xlou978 force-pushed the date-selection-model branch 2 times, most recently from c35acb1 to 5007110 Compare November 21, 2019 02:08
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 nit

@@ -75,12 +78,22 @@ export class MatSingleDateSelectionModel<D> extends MatDateSelectionModel<D> {
this._date = date;
this._valueChangesSubject.next();
}
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline before

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@xlou978 xlou978 force-pushed the date-selection-model branch from 5007110 to 0a0ea04 Compare November 21, 2019 19:31
@mmalerba mmalerba merged commit 47e1b01 into angular:date-selection-model Nov 21, 2019
@mmalerba mmalerba changed the title Date selection model Make the selection model injectable and add an overlaps method Nov 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants