Skip to content

Adds a date selection model #17363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2019
Merged

Adds a date selection model #17363

merged 2 commits into from
Oct 11, 2019

Conversation

xlou978
Copy link
Collaborator

@xlou978 xlou978 commented Oct 10, 2019

No description provided.

@xlou978 xlou978 requested a review from mmalerba as a code owner October 10, 2019 20:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 10, 2019
mmalerba
mmalerba requested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run bazel run //tools/public_api_guard:material/core.d.ts_api.accept to mark that the API changes in this PR are intentional

src/material/core/datetime/date-selection-model.ts Outdated
import {Subject} from 'rxjs';

export abstract class MatDateSelectionModel<D> {
valueChangesSubject = new Subject<void>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be private and we still need the valueChanges Observable for the public API. Just when you're calling .complete() and .next() those methods only exist on the Subject

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a private property, I won't be able to call this._valueChangesSubject in the derived classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, then you can make it protected, the important thing is its not part of the public API

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@xlou978 xlou978 requested a review from jelbourn as a code owner October 11, 2019 00:10
@xlou978
Copy link
Collaborator Author

xlou978 commented Oct 11, 2019 •
edited
Loading

My local tests all passed, not sure why the tests here are failing :-(

@mmalerba
Copy link
Contributor

I'm pretty sure that failure is just a flake, restarting it

mmalerba
mmalerba approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good to go once the tests are green

@mmalerba mmalerba merged commit c40a0fd into angular:date-selection-model Oct 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xlou978 @mmalerba @googlebot