build: set up all packages to publish via wombot proxy #17679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
force-pushed
the
wombot-release
branch
from
91a0b8e to
f9069b2
Compare
josephperrott
requested review from
jelbourn,
mmalerba and
a team
as code owners
josephperrott
added
pr: merge safe
target: patch
josephperrott
force-pushed
the
wombot-release
branch
from
f9069b2 to
4307b7e
Compare
devversion
approved these changes
Nov 12, 2019
devversion
added
pr: lgtm
action: merge
devversion
reviewed
Nov 12, 2019
tools/release/publish-release.ts
Outdated
| @@ -130,6 +130,9 @@ class PublishReleaseTask extends BaseReleaseTask { | |||
| console.info(chalk.green(chalk.bold(` ✓ Published all packages successfully`))); | |||
| console.info(chalk.yellow(` ⚠ Please draft a new release of the version on Github.`)); | |||
| console.info(chalk.yellow(` ${newReleaseUrl}`)); | |||
|
|
|||
| // Remove file at ~/.npmrc after release is complete. | |||
| spawnSync('rm', ['~/.npmrc'], {cwd: this.projectDir, stdio: 'inherit', shell: true}); | |||
There was a problem hiding this comment.
Why not use NodeJS unlinkSync? Not a big deal though, so I'm happy leaving it like that.
There was a problem hiding this comment.
Done, didn't even know it existed.
josephperrott
force-pushed
the
wombot-release
branch
from
ee90a21 to
35a5167
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.