release: remove npm login/logut/auth checks

Author: josephperrott

tools/release/npm/npm-client.ts

@@ -1,40 +1,12 @@
 import {spawnSync} from 'child_process';
 
-/**
- * Process environment that does not refer to Yarn's package registry. Since the scripts are
- * usually run through Yarn, we need to update the "npm_config_registry" so that NPM is able to
- * properly run "npm login" and "npm publish".
- */
-const npmClientEnvironment = {
-  ...process.env,
-  // See https://docs.npmjs.com/misc/registry for the official documentation of the NPM registry.
-  npm_config_registry: 'https://registry.npmjs.org',
-};
-
-/** Checks whether NPM is currently authenticated. */
-export function isNpmAuthenticated(): boolean {
-  return spawnSync('npm', ['whoami'], {
-    shell: true,
-    env: npmClientEnvironment,
-  }).stdout.toString() !== '';
-}
-
-/** Runs "npm login" interactively by piping stdin/stderr/stdout to the current tty. */
-export function npmLoginInteractive(): boolean {
-  return spawnSync('npm', ['login'], {
-    stdio: 'inherit',
-    shell: true,
-    env: npmClientEnvironment,
-  }).status === 0;
-}
-
 /** Runs NPM publish within a specified directory */
 export function npmPublish(packagePath: string, distTag: string): string | null {
   const result =
       spawnSync('npm', ['publish', '--access', 'public', '--tag', distTag], {
         cwd: packagePath,
         shell: true,
-        env: npmClientEnvironment,
+        env: process.env,
       });
 
   // We only want to return an error if the exit code is not zero. NPM by default prints the
@@ -44,11 +16,3 @@ export function npmPublish(packagePath: string, distTag: string): string | null
   }
   return null;
 }
-
-/** Log out of npm. */
-export function npmLogout(): boolean {
-  return spawnSync('npm', ['logout'], {
-    shell: true,
-    env: npmClientEnvironment,
-  }).status === 0;
-}

tools/release/publish-release.ts

@@ -7,21 +7,13 @@ import {checkReleaseOutput} from './check-release-output';
 import {extractReleaseNotes} from './extract-release-notes';
 import {GitClient} from './git/git-client';
 import {getGithubNewReleaseUrl} from './git/github-urls';
-import {
-  isNpmAuthenticated,
-  npmLogout,
-  npmLoginInteractive,
-  npmPublish,
-} from './npm/npm-client';
+import {npmPublish} from './npm/npm-client';
 import {promptForNpmDistTag} from './prompt/npm-dist-tag-prompt';
 import {promptForUpstreamRemote} from './prompt/upstream-remote-prompt';
 import {releasePackages} from './release-output/release-packages';
 import {CHANGELOG_FILE_NAME} from './stage-release';
 import {parseVersionName, Version} from './version-name/parse-version';
 
-/** Maximum allowed tries to authenticate NPM. */
-const MAX_NPM_LOGIN_TRIES = 2;
-
 /**
  * Class that can be instantiated in order to create a new release. The tasks requires user
  * interaction/input through command line prompts.
@@ -94,10 +86,6 @@ class PublishReleaseTask extends BaseReleaseTask {
       await this._promptStableVersionForNextTag();
     }
 
-    // Ensure that we are authenticated, so that we can run "npm publish" for
-    // each package once the release output is built.
-    this._checkNpmAuthentication();
-
     this._buildReleasePackages();
     console.info(chalk.green(`  ✓   Built the release output.`));
 
@@ -140,15 +128,6 @@ class PublishReleaseTask extends BaseReleaseTask {
 
     console.log();
     console.info(chalk.green(chalk.bold(`  ✓   Published all packages successfully`)));
-
-    // Always log out of npm after releasing to prevent unintentional changes to
-    // any packages.
-    if (npmLogout()) {
-      console.info(chalk.green(`  ✓   Logged out of npm`));
-    } else {
-      console.error(chalk.red(`  ✘   Could not log out of NPM. Please manually log out!`));
-    }
-
     console.info(chalk.yellow(`  ⚠   Please draft a new release of the version on Github.`));
     console.info(chalk.yellow(`      ${newReleaseUrl}`));
   }
@@ -201,40 +180,6 @@ class PublishReleaseTask extends BaseReleaseTask {
     }
   }
 
-  /**
-   * Checks whether NPM is currently authenticated. If not, the user will be prompted to enter
-   * the NPM credentials that are necessary to publish the release. We achieve this by basically
-   * running "npm login" as a child process and piping stdin/stdout/stderr to the current tty.
-   */
-  private _checkNpmAuthentication() {
-    if (isNpmAuthenticated()) {
-      console.info(chalk.green(`  ✓   NPM is authenticated.`));
-      return;
-    }
-
-    let failedAuthentication = false;
-    console.log(chalk.yellow(`  ⚠   NPM is currently not authenticated. Running "npm login"..`));
-
-    for (let i = 0;  i < MAX_NPM_LOGIN_TRIES; i++) {
-      if (npmLoginInteractive()) {
-        // In case the user was able to login properly, we want to exit the loop as we
-        // don't need to ask for authentication again.
-        break;
-      }
-
-      failedAuthentication = true;
-      console.error(chalk.red(`  ✘   Could not authenticate successfully. Please try again.`));
-    }
-
-    if (failedAuthentication) {
-      console.error(chalk.red(`  ✘   Could not authenticate after ${MAX_NPM_LOGIN_TRIES} tries. ` +
-        `Exiting..`));
-      process.exit(1);
-    }
-
-    console.info(chalk.green(`  ✓   Successfully authenticated NPM.`));
-  }
-
   /** Publishes the specified package within the given NPM dist tag. */
   private _publishPackageToNpm(packageName: string, npmDistTag: string) {
     console.info(chalk.green(`  ⭮   Publishing "${packageName}"..`));