Skip to content

docs(dialog): remove errant comma, adjust period use #17271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2019
Merged

docs(dialog): remove errant comma, adjust period use #17271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfbf30d
docs(dialog): remove errant comma, adjust period use
seiyria Oct 2, 2019
c631f58
docs(dialog): update wording to fit in 100 chars
seiyria Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/material/dialog/dialog-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class MatDialogConfig<D = any> {
/** Whether the dialog has a backdrop. */
hasBackdrop?: boolean = true;

/** Custom class for the backdrop, */
/** Custom class for the backdrop. */
backdropClass?: string = '';

/** Whether the user can use escape or clicking on the backdrop to close the modal. */
Expand All @@ -65,16 +65,16 @@ export class MatDialogConfig<D = any> {
/** Height of the dialog. */
height?: string = '';

/** Min-width of the dialog. If a number is provided, pixel units are assumed. */
/** Min-width of the dialog. If a number is provided, assumes pixel units. */
minWidth?: number | string;

/** Min-height of the dialog. If a number is provided, pixel units are assumed. */
/** Min-height of the dialog. If a number is provided, assumes pixel units. */
minHeight?: number | string;

/** Max-width of the dialog. If a number is provided, pixel units are assumed. Defaults to 80vw */
/** Max-width of the dialog. If a number is provided, assumes pixel units. Defaults to 80vw. */
maxWidth?: number | string = '80vw';

/** Max-height of the dialog. If a number is provided, pixel units are assumed. */
/** Max-height of the dialog. If a number is provided, assumes pixel units. */
maxHeight?: number | string;

/** Position overrides. */
Expand All @@ -92,7 +92,7 @@ export class MatDialogConfig<D = any> {
/** ID of the element that labels the dialog. */
ariaLabelledBy?: string | null = null;

/** Aria label to assign to the dialog element */
/** Aria label to assign to the dialog element. */
ariaLabel?: string | null = null;

/** Whether the dialog should focus the first focusable element on open. */
Expand Down