Skip to content

docs(dialog): remove errant comma, adjust period use #17271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2019
Merged

docs(dialog): remove errant comma, adjust period use #17271

merged 2 commits into from
Oct 3, 2019

Conversation

seiyria
Copy link
Contributor

@seiyria seiyria commented Oct 2, 2019

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 2, 2019
crisbeto
crisbeto approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the CI is failing due to some issue with Yarn.

@crisbeto crisbeto added docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 2, 2019
@ngbot
Copy link

ngbot bot commented Oct 2, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    pending status "ci/circleci: bazel_build" is pending
    pending status "ci/circleci: build_release_packages" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: ivy_test" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto removed pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 2, 2019
crisbeto
crisbeto reviewed Oct 2, 2019
View reviewed changes
src/material/dialog/dialog-config.ts Outdated
@@ -71,7 +71,7 @@ export class MatDialogConfig<D = any> {
/** Min-height of the dialog. If a number is provided, pixel units are assumed. */
minHeight?: number | string;

/** Max-width of the dialog. If a number is provided, pixel units are assumed. Defaults to 80vw */
/** Max-width of the dialog. If a number is provided, pixel units are assumed. Defaults to 80vw. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a lint failure here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Yeah, it looks like that was exactly the character to pass the line length restriction. I'm not sure what to do in this case, maybe make it a multi line comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically yes, you overflow to a multi-line comment. In this case, though, you could reword "pixel units are assumed" to "assumes pixel units"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll do that.

jelbourn
jelbourn approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 2, 2019
@mmalerba mmalerba merged commit b7ca14b into angular:master Oct 3, 2019
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
@seiyria @mmalerba
docs(dialog): remove errant comma, adjust period use (#17271)
0734f9d 
* docs(dialog): remove errant comma, adjust period use

* docs(dialog): update wording to fit in 100 chars

(cherry picked from commit b7ca14b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seiyria @jelbourn @crisbeto @googlebot @mmalerba