Skip to content

build: update bazel setup to rules_nodejs v0.38.0 #17249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Updates the rules_nodejs version to the latest version. This
is necessary to stay up-to-date and to unblock framework which
also wants to update to rules_nodejs#0.38.0.

This unblocks: angular/angular#32889.

@devversion devversion requested review from jelbourn and a team as code owners October 1, 2019 10:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 1, 2019
@devversion devversion changed the title build: update bazel setup to rules_nodejs#0.38.0 build: update bazel setup to rules_nodejs v0.38.0 Oct 1, 2019
Updates the `rules_nodejs` version to the latest version. This
is necessary to stay up-to-date and to unblock framework which
also wants to update to `rules_nodejs#0.38.0`.

This unblocks: angular/angular#32889.
@devversion devversion force-pushed the build/update-rules-nodejs-0.38.0 branch from d8a2785 to 177a6c7 Compare October 1, 2019 10:46
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 1, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 1, 2019
@jelbourn jelbourn merged commit 65a8c96 into angular:master Oct 1, 2019
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you 🌹

mmalerba pushed a commit that referenced this pull request Oct 8, 2019
Updates the `rules_nodejs` version to the latest version. This
is necessary to stay up-to-date and to unblock framework which
also wants to update to `rules_nodejs#0.38.0`.

This unblocks: angular/angular#32889.

(cherry picked from commit 65a8c96)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2019
@alexeagle alexeagle removed their assignment Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants