Skip to content

build: update to rules_nodejs 0.38 #32889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

build: update to rules_nodejs 0.38 #32889

wants to merge 6 commits into from

Conversation

alexeagle
Copy link
Contributor

No description provided.

@alexeagle alexeagle force-pushed the update_rules_nodejs branch 3 times, most recently from 1ba34ff to 2e2aa85 Compare September 27, 2019 22:52
@atscott atscott added the area: build & ci Related the build and CI infrastructure of the project label Sep 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 27, 2019
@alexeagle alexeagle force-pushed the update_rules_nodejs branch 2 times, most recently from b375c10 to 3005891 Compare September 28, 2019 04:21
@alexeagle
Copy link
Contributor Author

Caretaker: cl/271704225 needs to be patched in along with this change, so that the .mjs extensions remain .closure.js for google3

devversion added a commit to devversion/material2 that referenced this pull request Oct 1, 2019
@devversion
build: update bazel setup to rules_nodejs#0.38.0
d8a2785 
Updates the `rules_nodejs` version to the latest version. This
is necessary to stay up-to-date and to unblock framework which
also wants to update to `rules_nodejs#0.38.0`.

This unblocks: angular/angular#32889.
@devversion devversion mentioned this pull request Oct 1, 2019
Merged
devversion added a commit to devversion/material2 that referenced this pull request Oct 1, 2019
@devversion
build: update bazel setup to rules_nodejs v0.38.0
177a6c7 
Updates the `rules_nodejs` version to the latest version. This
is necessary to stay up-to-date and to unblock framework which
also wants to update to `rules_nodejs#0.38.0`.

This unblocks: angular/angular#32889.
jelbourn pushed a commit to angular/components that referenced this pull request Oct 1, 2019
@devversion @jelbourn
build: update bazel setup to rules_nodejs v0.38.0 (#17249)
65a8c96 
Updates the `rules_nodejs` version to the latest version. This
is necessary to stay up-to-date and to unblock framework which
also wants to update to `rules_nodejs#0.38.0`.

This unblocks: angular/angular#32889.
@alexeagle alexeagle force-pushed the update_rules_nodejs branch from 3005891 to 7a18b1d Compare October 2, 2019 16:07
@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added cla: no and removed cla: yes labels Oct 3, 2019
@devversion devversion force-pushed the update_rules_nodejs branch 2 times, most recently from 01ed06a to 4b1effa Compare October 3, 2019 10:38
@alexeagle alexeagle force-pushed the update_rules_nodejs branch from f96e6ad to 9eebd72 Compare October 4, 2019 21:39
@gregmagolan
Copy link
Contributor

@googlebot I consent

gregmagolan
gregmagolan reviewed Oct 5, 2019
View reviewed changes
@alexeagle alexeagle added cla: yes and removed cla: no labels Oct 7, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@alexeagle alexeagle marked this pull request as ready for review October 7, 2019 16:01
@alexeagle alexeagle requested review from IgorMinar and a team as code owners October 7, 2019 16:01
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Oct 7, 2019
@alexeagle alexeagle added cla: yes target: patch This PR is targeted for the next patch release and removed cla: no labels Oct 7, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@gregmagolan gregmagolan mentioned this pull request Oct 7, 2019
Merged
@alexeagle
Copy link
Contributor Author

CARETAKER: see note above about g3 CL needed to patch in with this

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2019
@alexeagle alexeagle added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 7, 2019
@alxhub alxhub added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Oct 8, 2019
@alxhub
Copy link
Member

alxhub commented Oct 8, 2019

Note: I'm merging this to master only as it does not apply cleanly on the patch branch. @alexeagle will open a separate PR for patch-only.

@alxhub alxhub closed this in f783244 Oct 8, 2019
alxhub pushed a commit that referenced this pull request Oct 8, 2019
@devversion @alxhub
ci: update material-unit-test commit (#32889)
3830f6f 
Updates the `material-unit-test` job to run tests against
the latest commit of the Angular Components repository.

We need to update to a version where components already
updated to `rules_nodejs#0.38.0`.

PR Close #32889
alxhub pushed a commit that referenced this pull request Oct 8, 2019
@devversion @alxhub
ci: avoid postinstall error when building material-unit-tests job (#3…
78ada98 
…2889)

The components repository updated to rules_nodejs#0.38.0 before Angular Bazel did.
To do this, the `@angular/bazel` v0.38.0 compatibility changes were patched on postinstall.

This now conflicts because we install a `@angular/bazel` version in the `material-unit-tests` job
that already includes these compatibility changes. This would result in the patch being a noop
for which the `patch` command throws an error.

We can remove this once components can install a released version of `@angular/bazel` that is
compatible with `rules_nodejs#0.38.0`.

PR Close #32889
alxhub pushed a commit that referenced this pull request Oct 8, 2019
@alexeagle @alxhub
build: add missing http-server dep to bazel example (#32889)
cdfbda3 
Also update rules_nodejs 0.38.0->0.38.1

PR Close #32889
alxhub pushed a commit that referenced this pull request Oct 8, 2019
@gregmagolan @alxhub
build: add JSEcmaScripModuleInfo provider to ng_module (#32889)
e1d07b2 
PR Close #32889
alxhub pushed a commit that referenced this pull request Oct 8, 2019
@gregmagolan @alxhub
build: add history-server to @angular/bazel schematics (#32889)
64823f5 
The history_server rule is not longer shipped with rules_nodejs as it has been replaced by auto-generated rule `load("@npm//history-server:index.bzl", "history_server")` which requires the user to add history-server to their package.json.

PR Close #32889
mmalerba pushed a commit to angular/components that referenced this pull request Oct 8, 2019
@devversion @mmalerba
build: update bazel setup to rules_nodejs v0.38.0 (#17249)
6fb6bda 
Updates the `rules_nodejs` version to the latest version. This
is necessary to stay up-to-date and to unblock framework which
also wants to update to `rules_nodejs#0.38.0`.

This unblocks: angular/angular#32889.

(cherry picked from commit 65a8c96)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gregmagolan gregmagolan gregmagolan left review comments

@JiaLiPassion JiaLiPassion JiaLiPassion approved these changes

@josephperrott josephperrott josephperrott approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
8 participants
@alexeagle @googlebot @gregmagolan @alxhub @JiaLiPassion @josephperrott @atscott @devversion