Skip to content

build: set up schematics for v9 #17101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2019
Merged

build: set up schematics for v9 #17101

merged 1 commit into from
Sep 16, 2019

Conversation

crisbeto
Copy link
Member

Adds the setup so we can add migration schematics for v9.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 16, 2019
@crisbeto
build: set up schematics for v9
f3bd17e 
Adds the setup so we can add migration schematics for v9.
@crisbeto crisbeto marked this pull request as ready for review September 16, 2019 19:43
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe target: major This PR is targeted for the next major release labels Sep 16, 2019
@crisbeto crisbeto mentioned this pull request Sep 16, 2019
Merged
devversion
devversion approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should figure out how many old versions we want to keep in the latest version. LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 16, 2019
jelbourn
jelbourn approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 7a433f6 into angular:master Sep 16, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @googlebot