-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor(drag-drop): remove deprecated APIs for 9.0.0 #17084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(drag-drop): remove deprecated APIs for 9.0.0 #17084
Conversation
fba9209
to
f67fc43
Compare
Should we have a migration for the renames? |
I'm not sure how many people are actually going to hit them. The only documented public API that was renamed is |
Isn't it trivial, though, to just add it to our migration data? I would still do it if it's not any major effort |
Looks like we don't have the schematics set up for v9. I've set them up in #17101. |
f67fc43
to
a168339
Compare
Added schematics where possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crisbeto We should be able to add We can also handle |
a168339
to
2d3fa97
Compare
Nice, added 👍. The only part I'm confused by is what the |
Yeah, I was confused about that rule at some point as well (i did not author it), but I guess it will print the given message if the arguments length matches the e.g. in that case you'd set it to the amount of params minus one (to match if the |
Cleans on the APIs that were marked as deprecated for 8.0 and 9.0. Also deprecates a few for 10.0 which were supposed to be removed in 9.0, but hadn't been marked correctly. BREAKING CHANGES: * `DropListRef.id` has been removed. * `CdkDragConfig` has been replaced with `DragRefConfig`. * `DragDropRegistry.getDropContainer` has been removed. * `CdkDropListContainer` interface has been removed. * `CDK_DROP_LIST_CONTAINER` has been replaced with `CDK_DROP_LIST`. * `CdkDrag.boundaryElementSelector` has been replaced with `CdkDrag.boundaryElement`. * `_ngZone` and `_viewportRuler` parameters in the `DropListRef` constructor are now required. * `distance` parameter in `DropListRef.drop` is now required.
2d3fa97
to
51349b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM schematic wise.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Cleans on the APIs that were marked as deprecated for 8.0 and 9.0. Also deprecates a few for 10.0 which were supposed to be removed in 9.0, but hadn't been marked correctly.
BREAKING CHANGES:
DropListRef.id
has been removed.CdkDragConfig
has been replaced withDragRefConfig
.DragDropRegistry.getDropContainer
has been removed.CdkDropListContainer
interface has been removed.CDK_DROP_LIST_CONTAINER
has been replaced withCDK_DROP_LIST
.CdkDrag.boundaryElementSelector
has been replaced withCdkDrag.boundaryElement
._ngZone
and_viewportRuler
parameters in theDropListRef
constructor are now required.distance
parameter inDropListRef.drop
is now required.