Skip to content

chore: fix menu harness tests #17018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2019
Merged

chore: fix menu harness tests #17018

merged 1 commit into from
Sep 9, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 9, 2019

Fixes a failure that wasn't caught by the CI in #17007 for some reason. We were only injecting the overlay container for one kind of test harness.

@crisbeto
chore: fix menu harness tests
22ee7fb 
Fixes a failure that wasn't caught by the CI in angular#17007 for some reason. We were only injecting the overlay container for one kind of test harness.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 9, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 9, 2019
crisbeto added a commit to crisbeto/material2 that referenced this pull request Sep 9, 2019
@crisbeto
build: disable test randomization
e84e5f6 
Since tests are randomized we missed some failures from angular#17018 until they reached master. These changes disable randomization like we used to have with our old setup.
@crisbeto crisbeto mentioned this pull request Sep 9, 2019
Closed
jelbourn
jelbourn approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 9, 2019
@jelbourn jelbourn merged commit 20f6eb9 into angular:master Sep 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot