test(material-experimental): harness tests leaking overlay containers #17007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the `cdk-overlay-container` nodes not being cleaned up between test harness tests.
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
Sep 8, 2019
|
Yeah the container is still there. Currently there will always be one, because we have some logic that clears all other containers, but once #17006 lands we'll leak one container per test. |
jelbourn
approved these changes
Sep 9, 2019
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 9, 2019
Fixes a failure that wasn't caught by the CI in angular#17007 for some reason. We were only injecting the overlay container for one kind of test harness.
jelbourn
pushed a commit
that referenced
this pull request
Sep 9, 2019
Fixes a failure that wasn't caught by the CI in #17007 for some reason. We were only injecting the overlay container for one kind of test harness.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
cdk-overlay-containernodes not being cleaned up between test harness tests.