Skip to content

build: create individual bazel targets for dev-app demos #16837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

devversion
Copy link
Member

Creates individual bazel targets for dev-app demos in favor of speeding
up development with Bazel.

Blocked on #16829

@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 21, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 21, 2019
@devversion devversion force-pushed the build/restructure-devapp branch 2 times, most recently from 7afcb14 to f2b14ee Compare August 21, 2019 18:48
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like some tasks are failing, though?

@devversion
Copy link
Member Author

@jelbourn Yeah, just started working on these. I can't see those failures locally since I don't have a real sandbox environment on windows.

@devversion devversion force-pushed the build/restructure-devapp branch 4 times, most recently from 0ee3a59 to 5b42d00 Compare August 21, 2019 19:18
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 21, 2019
@jelbourn jelbourn added pr: needs rebase and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Aug 21, 2019
@jelbourn
Copy link
Member

@devversion ready to merge if you can rebase

Creates individual bazel targets for dev-app demos in favor of speeding
up development with Bazel.
@devversion devversion force-pushed the build/restructure-devapp branch from 5b42d00 to 45c42cb Compare August 21, 2019 20:49
@devversion
Copy link
Member Author

@jelbourn Rebased.

@jelbourn jelbourn merged commit af3c9af into angular:master Aug 21, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
Creates individual bazel targets for dev-app demos in favor of speeding
up development with Bazel.

(cherry picked from commit af3c9af)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants