build: serve dev-app with bazel #16829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
devversion
force-pushed
the
build/bazel-devapp
branch
from
5654b85 to
58f5bc3
Compare
* Serves the dev-app with Bazel using `ts_devserver` (windows compatible since bazelbuild/rules_typescript@4155687) * Serves dev-app with AOT mode. * ibazel can be used for watch-mode and live-reloading Currently due to limitations within the `ts_devserver` rule, livereloading with ibazel is not working. Manual reloading still works.
devversion
force-pushed
the
build/bazel-devapp
branch
from
58f5bc3 to
c956bb9
Compare
josephperrott
approved these changes
Aug 20, 2019
| # Job that builds the dev-app with AOT. In order to speed up this job, the release output | ||
| # from the workspace storage will be attached to this job. | ||
| # ----------------------------------------------------------------------------------------- | ||
| build_devapp_aot: |
There was a problem hiding this comment.
Should we still build the devapp as a test?
There was a problem hiding this comment.
It will be built as part of the bazel build job.
jelbourn
approved these changes
Aug 20, 2019
| "test": "bazel test //src/... --test_tag_filters=-e2e,-browser:firefox-local --build_tag_filters=-browser:firefox-local --build_tests_only", | ||
| "test-firefox": "bazel test //src/... --test_tag_filters=-e2e,-browser:chromium-local --build_tag_filters=-browser:chromium-local --build_tests_only", | ||
| "lint": "gulp lint && yarn -s bazel:format-lint", | ||
| "e2e": "bazel test //src/... --test_tag_filters=e2e", | ||
| "deploy": "gulp deploy:devapp", | ||
| "deploy": "echo 'Not supported yet. Tracked with COMP-230'", |
There was a problem hiding this comment.
I moved this to the queue since I want to keep this deploy functional; we'll likely want to do some amount of IE and mobile testing with the MDC components as we progress
jelbourn
added
pr: lgtm
action: merge
|
We're going to hold off on merging this until follow-up work to speed up the dev-app rebuild by making the targets more granular |
devversion
removed
the
blocked
|
@jelbourn I'll re-add merge ready as the other PR is approved and ready. Feel free to remove if you think something is still missing. |
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
* Serves the dev-app with Bazel using `ts_devserver` (windows compatible since bazelbuild/rules_typescript@4155687) * Serves dev-app with AOT mode. * ibazel can be used for watch-mode and live-reloading Currently due to limitations within the `ts_devserver` rule, livereloading with ibazel is not working. Manual reloading still works. (cherry picked from commit 1162048)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts_devserver(windowscompatible since
bazelbuild/rules_typescript@4155687)
Currently due to limitations within the
ts_devserverrule, livereloading with ibazel is notworking. Manual reloading still works. Created bazel-contrib/rules_nodejs#1036 for tracking.
Additionally rebuilding seems at first glance slower as with the gulp setup. This is because the
dev-apphas the same problem as thematerial-examplesand ideally it would have a bazel package file per module (modules are already available due to lazy loading)