Skip to content

chore: changed unused variables from build error to lint error #16544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2019
Merged

chore: changed unused variables from build error to lint error #16544

merged 1 commit into from
Jul 17, 2019

Conversation

jelbourn
Copy link
Member

This compiler flag really has no business being a compiler flag and
makes debugging a pain.

@jelbourn jelbourn added pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 16, 2019
@jelbourn jelbourn requested review from crisbeto and devversion July 16, 2019 23:04
@jelbourn jelbourn requested a review from mmalerba as a code owner July 16, 2019 23:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 16, 2019
devversion
devversion approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tslint rule is actually deprecated, but considering that tslint is also deprecated.. it shouldn't be a problem doing this for now.

LGTM.

@devversion
Copy link
Member

@jelbourn In regards to the noUnusedParameters flag, should we do the same for the noUnusedLocals flag? I think that one is also covered by the no-unused-variables tslint rule.

crisbeto
crisbeto approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it does log a warning now:

no-unused-variable is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead.

@jelbourn
chore: changed unused variables from build error to lint error
b44a8e8 
This compiler flag really has no business being a compiler flag and
makes debugging a pain.
@jelbourn jelbourn force-pushed the unused-variables-gosh-darn-it branch from 9964fbb to b44a8e8 Compare July 17, 2019 16:21
@jelbourn
Copy link
Member Author

Changed to also turn off noUnusedLocals. I'm okay with the warning since it's less annoying than trying to debug and getting build failures because you commented something out.

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 17, 2019
@jelbourn jelbourn merged commit 1c75040 into angular:master Jul 17, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
@jelbourn @andrewseguin
chore: changed unused variables from build error to lint error (#16544)
d670949 
This compiler flag really has no business being a compiler flag and
makes debugging a pain.

(cherry picked from commit 1c75040)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @devversion @crisbeto @googlebot