chore: changed unused variables from build error to lint error

jelbourn · jelbourn · commit 9964fbbb7899 · 2019-07-16T16:00:20.000-07:00
This compiler flag really has no business being a compiler flag and
makes debugging a pain.
diff --git a/src/bazel-tsconfig-build.json b/src/bazel-tsconfig-build.json
@@ -9,7 +9,7 @@
     "declaration": true,
     "stripInternal": false,
     "experimentalDecorators": true,
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noUnusedLocals": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
diff --git a/src/dev-app/tsconfig-aot.json b/src/dev-app/tsconfig-aot.json
@@ -6,7 +6,7 @@
     // Needed for Moment.js since it doesn't have a default export.
     "allowSyntheticDefaultImports": true,
     "experimentalDecorators": true,
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noUnusedLocals": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
diff --git a/src/dev-app/tsconfig-build.json b/src/dev-app/tsconfig-build.json
@@ -7,7 +7,7 @@
     "declaration": false,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noUnusedLocals": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
diff --git a/src/material-examples/tsconfig-build.json b/src/material-examples/tsconfig-build.json
@@ -7,7 +7,7 @@
     "declaration": true,
     "stripInternal": false,
     "experimentalDecorators": true,
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noUnusedLocals": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
diff --git a/src/material-moment-adapter/tsconfig-build.json b/src/material-moment-adapter/tsconfig-build.json
@@ -7,7 +7,7 @@
     "declaration": true,
     "stripInternal": false,
     "experimentalDecorators": true,
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noUnusedLocals": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
diff --git a/src/material/schematics/tsconfig.json b/src/material/schematics/tsconfig.json
@@ -8,7 +8,7 @@
     "strictNullChecks": true,
     "skipDefaultLibCheck": true,
     "noUnusedLocals": true,
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "skipLibCheck": true,
     "sourceMap": true,
     "declaration": true,
diff --git a/src/universal-app/tsconfig-build.json b/src/universal-app/tsconfig-build.json
@@ -5,7 +5,7 @@
     "declaration": true,
     "stripInternal": false,
     "experimentalDecorators": true,
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noUnusedLocals": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
diff --git a/src/universal-app/tsconfig-prerender.json b/src/universal-app/tsconfig-prerender.json
@@ -4,7 +4,7 @@
     "declaration": false,
     "stripInternal": false,
     "experimentalDecorators": true,
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noUnusedLocals": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
diff --git a/tools/dgeni/tsconfig.json b/tools/dgeni/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noUnusedLocals": true,
     "lib": ["es2015", "dom", "es2016.array.include"],
     "moduleResolution": "node",
diff --git a/tools/gulp/tsconfig.json b/tools/gulp/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "compilerOptions": {
     "experimentalDecorators": true,
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noUnusedLocals": true,
     "lib": ["es2015", "dom", "es2016.array.include"],
     "module": "commonjs",
diff --git a/tsconfig.json b/tsconfig.json
@@ -6,7 +6,7 @@
     "experimentalDecorators": true,
     "module": "es2015",
     "moduleResolution": "node",
-    "noUnusedParameters": true,
+    "noUnusedParameters": false,
     "noFallthroughCasesInSwitch": true,
     "noUnusedLocals": true,
     "strictNullChecks": true,
diff --git a/tslint.json b/tslint.json
@@ -27,6 +27,7 @@
     "no-bitwise": true,
     "no-shadowed-variable": true,
     "no-unused-expression": true,
+    "no-unused-variable": true,
     "no-var-keyword": true,
     "member-access": [true, "no-public"],
     "no-debugger": true,

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"compilerOptions": {`
`3`		`- "noUnusedParameters": true,`
	`3`	`+ "noUnusedParameters": false,`
`4`	`4`	`"noUnusedLocals": true,`
`5`	`5`	`"lib": ["es2015", "dom", "es2016.array.include"],`
`6`	`6`	`"moduleResolution": "node",`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"compilerOptions": {`
`3`	`3`	`"experimentalDecorators": true,`
`4`		`- "noUnusedParameters": true,`
	`4`	`+ "noUnusedParameters": false,`
`5`	`5`	`"noUnusedLocals": true,`
`6`	`6`	`"lib": ["es2015", "dom", "es2016.array.include"],`
`7`	`7`	`"module": "commonjs",`