build: publish-release script should run npm login before build #16188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the release packages can take up a lot of time and we should rather run `npm login` before starting the build because otherwise if the login fails, the output needs to be rebuilt again. Additionally this commit fixes that existing local/remote tags are not properly parsed due to an issue with the Git references that refer to tags. Closes angular#16141
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
added
the
P3
josephperrott
pushed a commit
that referenced
this pull request
Jun 10, 2019
Building the release packages can take up a lot of time and we should rather run `npm login` before starting the build because otherwise if the login fails, the output needs to be rebuilt again. Additionally this commit fixes that existing local/remote tags are not properly parsed due to an issue with the Git references that refer to tags. Closes #16141
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…lar#16188) Building the release packages can take up a lot of time and we should rather run `npm login` before starting the build because otherwise if the login fails, the output needs to be rebuilt again. Additionally this commit fixes that existing local/remote tags are not properly parsed due to an issue with the Git references that refer to tags. Closes angular#16141
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the release packages can take up a lot of time and we
should rather run
npm loginbefore starting the build becauseotherwise if the login fails, the output needs to be rebuilt again.
Additionally this commit fixes that existing local/remote tags are
not properly parsed due to an issue with the Git references that
refer to tags.
Closes #16141