Move npm login check before building in publish-release

[jelbourn]

I accidentally failed npm login twice today and had to wait through the whole build again.

[jelbourn]

Also it pushed the tag to upstream and subsequently publish failed because the tag already exists

[devversion]

@jelbourn Fair point with the npm login thing. Thinking about the tag issue you also mentioned. We actually have logic that should use the existing remote/local tag if it refers to the proper SHA.

Do you remember the output of the release staging tool? Was it complaining about the tag existing locally or remotely?

Edit: I was able to reproduce it. PR that fixes this is ready for review 😄

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}