Skip to content

Revert "refactor: mark injectable refs with @Injectable" #16079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2019

Conversation

mmalerba
Copy link
Contributor

Reverts #15584

Caused warnings while building:

Warning: Can't resolve all parameters for MatDialogRef in .../components/dist/packages/material/dialog/dialog-ref.d.ts: ([object Object], [object Object], [object Object], ?). This will become an error in Angular v6.x

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 21, 2019
@mmalerba mmalerba merged commit 9519192 into master May 21, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
@josephperrott josephperrott deleted the revert-15584-ref-injectable branch June 29, 2022 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants