Skip to content

refactor: mark injectable refs with @Injectable #15584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2019
Merged

refactor: mark injectable refs with @Injectable #15584

merged 1 commit into from
May 21, 2019

Conversation

jelbourn
Copy link
Member

Marks MatDialogRef, MatSnackbarRef, and MatBottomSheetRef as
@Injectable. Though this isn't strictly necessary because they're
injected via PortalInjector, it makes them consistent with other
injectable things.

@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Mar 22, 2019
@jelbourn jelbourn requested a review from crisbeto March 22, 2019 23:31
@jelbourn jelbourn requested a review from josephperrott as a code owner March 22, 2019 23:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 22, 2019
crisbeto
crisbeto approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 23, 2019
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@jelbourn
refactor: mark injectable refs with @Injectable
d1fab6d 
Marks `MatDialogRef`, `MatSnackbarRef`, and `MatBottomSheetRef` as
`@Injectable`. Though this isn't strictly necessary because they're
injected via `PortalInjector`, it makes them consistent with other
injectable things.
@mmalerba mmalerba merged commit 0908be7 into angular:master May 21, 2019
mmalerba added a commit that referenced this pull request May 21, 2019
@mmalerba
Revert "refactor: mark injectable refs with @Injectable (#15584)"
8465441 
This reverts commit 0908be7.
@mmalerba mmalerba mentioned this pull request May 21, 2019
Merged
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@jelbourn @RudolfFrederiksen
refactor: mark injectable refs with @Injectable (angular#15584)
f16ec2f 
Marks `MatDialogRef`, `MatSnackbarRef`, and `MatBottomSheetRef` as
`@Injectable`. Though this isn't strictly necessary because they're
injected via `PortalInjector`, it makes them consistent with other
injectable things.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @crisbeto @googlebot @mmalerba