Skip to content

cleanup(build): some bazel related cleanup #15644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 28, 2019

  • Removed unused dep in e2e-app
  • Updates rules_sass

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe labels Mar 28, 2019
@mmalerba mmalerba requested review from jelbourn and devversion March 28, 2019 23:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 28, 2019
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the unused dep removal and sass update.

Not sure about the changes to the highlight.js build file. That shouldn't be necessary. I think the CI issue is related to some transitive dependency issue that is caused by a change in the TypeScript rules.

.bazelignore Outdated
@@ -1 +1,3 @@
node_modules
tools/dashboard/node_modules
tools/dashboard/functions/node_modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't know where this came from, there's nothing under tools/dashboard other than node_modules directories.

I was seeing some issues when running bazel build ... that seemed to be fixed by the highlight.js stuff I added

@mmalerba mmalerba force-pushed the bazel branch 2 times, most recently from 23f3bfb to 5be0236 Compare March 29, 2019 20:22
@mmalerba
Copy link
Contributor Author

#15649 resolved the highlight.js issue, reverted the change in this PR

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should remove the dashboard stuff as there is no dashboard folder in the repo. This probably showed up because node_modules are git-ignored and you installed the deps of the dashboard back when it still existed?

@mmalerba
Copy link
Contributor Author

mmalerba commented Apr 1, 2019

ahh that explains it, will fix

- Removed unused dep in e2e-app
- Updates rules_sass
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 1, 2019
@mmalerba mmalerba merged commit 4b93a6e into angular:master Apr 1, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants