-
Notifications
You must be signed in to change notification settings - Fork 6.8k
cleanup(build): some bazel related cleanup #15644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the unused dep removal and sass update.
Not sure about the changes to the highlight.js build file. That shouldn't be necessary. I think the CI issue is related to some transitive dependency issue that is caused by a change in the TypeScript rules.
.bazelignore
Outdated
@@ -1 +1,3 @@ | |||
node_modules | |||
tools/dashboard/node_modules | |||
tools/dashboard/functions/node_modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't know where this came from, there's nothing under tools/dashboard
other than node_modules
directories.
I was seeing some issues when running bazel build ...
that seemed to be fixed by the highlight.js stuff I added
23f3bfb
to
5be0236
Compare
#15649 resolved the highlight.js issue, reverted the change in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we should remove the dashboard stuff as there is no dashboard
folder in the repo. This probably showed up because node_modules
are git-ignored and you installed the deps of the dashboard back when it still existed?
ahh that explains it, will fix |
- Removed unused dep in e2e-app - Updates rules_sass
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Uh oh!
There was an error while loading. Please reload this page.