-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: add bazel config for cdk-experimental/dialog #11548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1 @@ | |||
declare var module: {id: string}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note on this one: I still can't find a way to get Bazel to pick up the typings.d.ts
that is one level up in cdk-experimental
. This is also something that came up in #11481. Changing it in the tsconfig works when running it through Gulp, but not through Bazel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's expected; Bazel doesn't allow referencing source files that aren't in the package's subtree; if you wanted to reference a common d.ts
file, you have to create a build rule for it and depend on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crisbeto Please rebase when you can |
Adds the BUILD.bazel file for the `@angular/cdk-experimental/dialog` package for consistency with everything else and to make it easier to eventually move it into the CDK.
4a97994
to
9a8919d
Compare
Rebased. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds the BUILD.bazel file for the
@angular/cdk-experimental/dialog
package for consistency with everything else and to make it easier to eventually move it into the CDK.