Skip to content

Revert "fix(tabs): handle long tab labels in mat-tab-nav-bar (#10903)" #11277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2018

Conversation

jelbourn
Copy link
Member

This reverts commit 61dd937.

@crisbeto this interferes with some places that customize the height of the mat-tab-link, reverting to unblock syncing

@jelbourn jelbourn requested a review from andrewseguin May 10, 2018 22:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 10, 2018
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 10, 2018
@ngbot
Copy link

ngbot bot commented May 10, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    pending status "ci/circleci: build" is pending
    pending status "branch manager" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit ab17996 into angular:master May 10, 2018
jelbourn added a commit to jelbourn/components that referenced this pull request May 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants