Skip to content

fix(tabs): handle long tab labels in mat-tab-nav-bar #10903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2018
Merged

fix(tabs): handle long tab labels in mat-tab-nav-bar #10903

merged 1 commit into from
May 10, 2018

Conversation

crisbeto
Copy link
Member

Fixes the mat-tab-link not handling long text strings.

@crisbeto
fix(tabs): handle long tab labels in mat-tab-nav-bar
9197506 
Fixes the `mat-tab-link` not handling long text strings.
@crisbeto crisbeto requested a review from andrewseguin as a code owner April 18, 2018 00:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 18, 2018
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 24, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 24, 2018
@jelbourn jelbourn added presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged and removed presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged labels May 9, 2018
@jelbourn jelbourn merged commit 61dd937 into angular:master May 10, 2018
jelbourn added a commit to jelbourn/components that referenced this pull request May 10, 2018
@jelbourn
Revert "fix(tabs): handle long tab labels in mat-tab-nav-bar (angular…
148db3b 
…#10903)"

This reverts commit 61dd937.
jelbourn added a commit that referenced this pull request May 10, 2018
@jelbourn
Revert "fix(tabs): handle long tab labels in mat-tab-nav-bar (#10903)" (
ab17996 
#11277)

This reverts commit 61dd937.
jelbourn pushed a commit to jelbourn/components that referenced this pull request May 14, 2018
@crisbeto @jelbourn
fix(tabs): handle long tab labels in mat-tab-nav-bar (angular#10903)
f5eda86 
Fixes the `mat-tab-link` not handling long text strings.
jelbourn added a commit to jelbourn/components that referenced this pull request May 14, 2018
@jelbourn
Revert "fix(tabs): handle long tab labels in mat-tab-nav-bar (angular…
06f5496 
…#10903)" (angular#11277)

This reverts commit 61dd937.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @andrewseguin @jelbourn @googlebot