virtual-scroll: allow user to pass Observable<T[]>
#10158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
whoops, think I broke some stuff, hold off on review until I fix it |
mmalerba
force-pushed
the
vs3
branch
2 times, most recently
from
9ec02dc to
69ec88a
Compare
|
Ok, while |
mmalerba
changed the title
Observable<NgIterable<T>>Observable<T[]>
jelbourn
reviewed
Feb 28, 2018
| @@ -35,7 +35,7 @@ import {CdkVirtualScrollViewport} from './virtual-scroll-viewport'; | |||
| /** The context for an item rendered by `CdkVirtualForOf` */ | |||
| export type CdkVirtualForOfContext<T> = { | |||
| $implicit: T; | |||
| cdkVirtualForOf: NgIterable<T> | DataSource<T>; | |||
| cdkVirtualForOf: DataSource<T> | Observable<T[]> | NgIterable<T>; | |||
There was a problem hiding this comment.
I'm confused about this WRT your comment about needing the length (vs having NgIterable here)
There was a problem hiding this comment.
I was originally going to support Observable<NgIterable<T>>, but decided there wasn't really much point. Still want to support plain NgIterable<T> so that you can pass all of the same stuff to *cdkVirtualFor that you would to *ngFor
jelbourn
added
pr: lgtm
action: merge
mmalerba
added a commit
that referenced
this pull request
Mar 7, 2018
mmalerba
added a commit
that referenced
this pull request
Mar 9, 2018
mmalerba
added a commit
that referenced
this pull request
Mar 19, 2018
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Apr 5, 2018
mmalerba
added a commit
that referenced
this pull request
May 22, 2018
* feat(virtual-scroll): fixed size virtual scroll (#9316) * feat(virtual-scroll): fixed size virtual scroll * address some comments * change VirtualScrollStrategy interface a bit * address some more comments * fix lint & build * chore: move virtual-scroll to cdk-experimental (#9974) * virtual-scroll: simplify scroll listener logic (#10102) * virtual-scroll: only move views that need to be moved (#10099) * virtual-scroll: only move views that need to be moved * address comments * virtual-scroll: switch `throttleTime` to `sampleTime` (#10179) * virtual-scroll: switch throttleTime to sampleTime * add comment * virtual-scroll: allow user to pass `Observable<T[]>` (#10158) * virtual-scroll: rename `Range` to `ListRange` to avoid confusion with native `Range` (#10220) * virtual-scroll: add autosize scroll strategy (#10219) * rename fixed size virtual scroll directive * add autosize virtual scroll strategy * add item size estimator class * add logic for jumping rendered content based on scroll position * address comments * virtual-scroll: add `onContentRendered` hook to `VirtualScrollStrategy` (#10290) * virtual-scroll: add `onContentRendered` hook to `VirtualScrollStrategy` * address comemnts * virtual-scroll: add incremental scroll logic in `AutosizeVirtualScrollStrategy` (#10504) * virtual-scroll: add incremental scroll logic in `AutosizeVirtualScrollStrategy`. This still has a couple issues that need to be ironed out and it doesn't have the code for correcting the error between the predicted and actual scroll position. (See various TODOs for additional things that need work). * fix lint * address comments * address comments * fix bazel * fix devapp * fix lint * cleanup * virtual-scroll: rewrite offset in terms of "to-top" and fix a bug where items were removed too soon (#10986) * rewrite offsets to the end of the rendered content as offsets to the start * add some more autosize demos for testing * make sure not to remove too many items * address comments * virtual-scroll: address amcdnl's feedback (#10988) * rewrite offsets to the end of the rendered content as offsets to the start * add some more autosize demos for testing * make sure not to remove too many items * virtual-scroll: address amcdnl's feedback * virtual-scroll: fix updating when data changes and add trackBy demos (#11085) * virtual-scroll: add logic to correct the scroll position as user move… (#11137) * virtual-scroll: add logic to correct the scroll position as user moves toward the top * address comments * fix(scrolling): adds right to fix pushed content (#11192) * fix(scrolling): adds right to fix pushed content * chore: address feedback * chore: address pr feedback * virtual-scroll: add tests for fixed size items (#11255) * virtual-scroll: add tests for fixed size items * address comments * fix bug in fixed size strategy * fix bazel build * virtual-scroll: add tests for `cdkVirtualFor` logic (#11275) * merge fixed size test components into one * add tests for cdkVirtualFor logic * allow undefined to be explicitly passed as trackBy * fix bazel build * address comments * add some basic tests (#11295) * fix lint * virtual-scroll: add e2e tests for autosize scroll strategy (#11345) * set up virtual scroll page in e2e app * add gulp task for e2e:watch * add e2e tests for autosize * address comments * address comments * fix lint and tests * fix bad rebase * fix(scrolling): scrollbar jump when data change on scroll (#11193) * fix(scrolling): data change not updating size * chore: remove todo * chore: more performant fix for jump
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenience, the user is allowed to pass
DataSource<T>,NgIterable<T>, orObservable<NgIterable<T>>to the virtual scroller. It will be automatically converted into aDataSourceso that the same logic can be used no matter what the user passes.Fixes #10120
@andrewseguin @tinayuangao do you guys do something like this for tree and table? We probably should do it for all three for consistency.