Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add fraction size parameter to currencyFilter #7582

Closed
wants to merge 1 commit into from

Conversation

genuinefafa
Copy link

feat(filter): currencyFilter and numberFilter should have same fraction behavior

currencyFilter now accepts fractionSize so it behaves "similar" to a numberFilter, it even uses locale patterns by default.

currencyFilter now accepts fractionSize so it behaves "similar" to a numberFilter, it even uses locale patterns
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7582)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@genuinefafa
Copy link
Author

I just sent the email with the signed CLA for my company.
The company's name is Soluciones 3f SRL.

I'm guessing that's it. Please, @mary-poppins, let me know if I need to do something else.

@Narretz Narretz added this to the Backlog milestone Jun 26, 2014
@Narretz Narretz changed the title Update filters.js Add fraction size parameter to currencyFilter Jul 9, 2014
@Narretz
Copy link
Contributor

Narretz commented Jul 9, 2014

I updated the title to reflect the changes

@petebacondarwin
Copy link
Contributor

I think this could be combined with #5672

@genuinefafa
Copy link
Author

Yes @petebacondarwin, you might be right. I think I should also update the tests... I'll do it soon!

"My" fix is much "easier", since I was trying to reproduce the behavior of the numberFormat, #5672 does some aditional behavior, which I dont entirely agree with.

@park9140
Copy link

If you look at the code, #5672 does not 'extend' behavior. It make code that was already there doing nothing actually get run. I just made the original intent not broken.

@park9140
Copy link

Also I totally already did this and wrote tests for it in #5674.

@petebacondarwin
Copy link
Contributor

@park9140 you are right. I didn't see that pr. Closing this as a duplicate of #5674

@genuinefafa
Copy link
Author

Let's hope angular folks add the feature! ;) @park9140 @petebacondarwin 👯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants